Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone entire repo in "Lint" action #1052

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Clone entire repo in "Lint" action #1052

merged 1 commit into from
Jul 8, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 8, 2022

Closes #1051.

@jwodder jwodder added the internal Changes only affect the internal API label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (616ecfc) to head (b8a7bef).
Report is 1064 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   88.42%   88.40%   -0.03%     
==========================================
  Files          71       71              
  Lines        9149     9159      +10     
==========================================
+ Hits         8090     8097       +7     
- Misses       1059     1062       +3     
Flag Coverage Δ
unittests 88.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

hm, one run failed with (unrelated to this diff)

=================================== FAILURES ===================================
________________________ test_upload_dandiset_metadata _________________________
dandi/tests/test_upload.py:59: in test_upload_dandiset_metadata
    assert d.version.name == "shorty"
E   AssertionError: assert 'Sample Dandi...iset_metadata' == 'shorty'
E     - shorty
E     + Sample Dandiset for test_upload_dandiset_metadata
------------------------------ Captured log setup ------------------------------
DEBUG    dandi:dandiapi.py:199 POST http://localhost:8000/api/dandisets/
DEBUG    dandi:dandiapi.py:246 Response: 200
------------------------------ Captured log call -------------------------------
DEBUG    dandi:dandiapi.py:199 GET http://localhost:8000/api/info/
DEBUG    dandi:dandiapi.py:246 Response: 200
DEBUG    dandi:dandiapi.py:199 GET http://localhost:8000/api/auth/token
DEBUG    dandi:dandiapi.py:246 Response: 200
DEBUG    dandi:dandiset.py:102 Found identifier 000195 in top level 'identifier'
INFO     dandi:upload.py:103 Found 1 files to consider
DEBUG    dandi:dandiapi.py:199 PUT http://localhost:8000/api/dandisets/000195/versions/draft/
DEBUG    dandi:dandiapi.py:246 Response: 200
DEBUG    dandi:dandiapi.py:199 GET http://localhost:8000/api/dandisets/000195/
DEBUG    dandi:dandiapi.py:246 Response: 200
---------- coverage: platform linux, python 3.7.13-final-0 -----------
Coverage XML written to file coverage.xml
============================= slowest 10 durations =============================
79.11s setup    dandi/cli/tests/test_service_scripts.py::test_cancel_zarr_upload
9.42s call     dandi/tests/test_dandiapi.py::test_publish_and_manipulate
8.76s call     dandi/tests/test_dandiapi.py::test_get_dandiset_published_other_version[True]
8.51s call     dandi/tests/test_dandiapi.py::test_get_dandiset_published_other_version[False]
7.64s call     dandi/tests/test_dandiapi.py::test_get_many_pages_of_assets
6.78s call     dandi/tests/test_upload.py::test_upload_different_zarr_entry_conflicts
6.44s call     dandi/tests/test_upload.py::test_upload_different_zarr_file_to_parent_dir
6.23s call     dandi/tests/test_download.py::test_download_000027[https://dandiarchive.org/dandiset/000027/draft]
6.18s call     dandi/tests/test_download.py::test_download_000027[https://dandiarchive.org/dandiset/000027/0.210831.2033]
5.60s call     dandi/tests/test_organize.py::test_organize_nwb_test_data[dry]
=========================== short test summary info ============================
FAILED dandi/tests/test_upload.py::test_upload_dandiset_metadata - AssertionE...
============= 1 failed, 585 passed, 5 xfailed in 839.73s (0:13:59) =============
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:191: UserWarning: Stimulus description 'NA' for IZeroClampSeries 'izcs' is ignored and will be set to 'N/A' as per NWB 2.3.0.
  % (current_stim_desc, self.__class__.__name__, name, stim_desc, nwb_version))
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:24: UserWarning: Unit 'A' for IZeroClampSeries 'izcs' is ignored and will be set to 'volts' as per NWB 2.1.0.
  % (current_unit, self.__class__.__name__, name, unit, nwb_version))
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:24: UserWarning: Unit 'A' for VoltageClampStimulusSeries 'vcss' is ignored and will be set to 'volts' as per NWB 2.1.0.
  % (current_unit, self.__class__.__name__, name, unit, nwb_version))
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:24: UserWarning: Unit 'A' for CurrentClampStimulusSeries 'ccss' is ignored and will be set to 'amperes' as per NWB 2.1.0.
  % (current_unit, self.__class__.__name__, name, unit, nwb_version))
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/image.py:85: UserWarning: TwoPhotonSeries 'test_2ps': Length of data does not match length of timestamps. Your data may be transposed. Time should be on the 0th dimension
  "Time should be on the 0th dimension" % (self.__class__.__name__, self.name)
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:24: UserWarning: Unit 'A' for CurrentClampSeries 'ccs' is ignored and will be set to 'volts' as per NWB 2.1.0.
  % (current_unit, self.__class__.__name__, name, unit, nwb_version))
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pynwb/icephys.py:24: UserWarning: Unit 'A' for VoltageClampSeries 'vcs' is ignored and will be set to 'amperes' as per NWB 2.1.0.
  % (current_unit, self.__class__.__name__, name, unit, nwb_version))
Error: Process completed with exit code 1.

Let's proceed, thanks @jwodder !

@yarikoptic yarikoptic merged commit ddf46f2 into master Jul 8, 2022
@yarikoptic yarikoptic deleted the gh-1051 branch July 8, 2022 19:39
@github-actions
Copy link

🚀 PR was released in 0.45.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make linters happy
2 participants